From 21d436cae03465cbc2a72c230d8d02d03e7eb59b Mon Sep 17 00:00:00 2001
From: Eric Zhao <sczyh16@gmail.com>
Date: Fri, 15 Mar 2019 10:03:14 +0800
Subject: [PATCH] Fix pmd configuration in pom.xml

Signed-off-by: Eric Zhao <sczyh16@gmail.com>
---
 pom.xml                    |  8 ++++++--
 sentinel-benchmark/pom.xml | 18 +++++++++++++++++-
 2 files changed, 23 insertions(+), 3 deletions(-)

diff --git a/pom.xml b/pom.xml
index d6193397..ba3792e1 100755
--- a/pom.xml
+++ b/pom.xml
@@ -62,6 +62,7 @@
         <maven.gpg.version>1.6</maven.gpg.version>
         <maven.jacoco.version>0.8.3</maven.jacoco.version>
         <maven.jar.version>3.1.0</maven.jar.version>
+        <maven.pmd.version>3.8</maven.pmd.version>
     </properties>
 
     <modules>
@@ -189,10 +190,13 @@
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-pmd-plugin</artifactId>
-                <version>3.8</version>
+                <version>${maven.pmd.version}</version>
                 <configuration>
                     <sourceEncoding>${project.build.sourceEncoding}</sourceEncoding>
-                    <targetJdk>1.8</targetJdk>
+                    <minimumPriority>1</minimumPriority>
+                    <excludeRoots>
+                        <excludeRoot>com/alibaba/csp/sentinel/benchmark</excludeRoot>
+                    </excludeRoots>
                     <excludes>
                         <exclude>**/*_jmhTest.java</exclude>
                     </excludes>
diff --git a/sentinel-benchmark/pom.xml b/sentinel-benchmark/pom.xml
index 2270b38a..af32b952 100644
--- a/sentinel-benchmark/pom.xml
+++ b/sentinel-benchmark/pom.xml
@@ -49,13 +49,29 @@
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-compiler-plugin</artifactId>
-                <version>3.8.0</version>
+                <version>${maven.compiler.version}</version>
                 <configuration>
                     <compilerVersion>${javac.target}</compilerVersion>
                     <source>${javac.target}</source>
                     <target>${javac.target}</target>
                 </configuration>
             </plugin>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-pmd-plugin</artifactId>
+                <version>${maven.pmd.version}</version>
+                <configuration>
+                    <skip>true</skip>
+                </configuration>
+            </plugin>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-deploy-plugin</artifactId>
+                <version>${maven.deploy.version}</version>
+                <configuration>
+                    <skip>true</skip>
+                </configuration>
+            </plugin>
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-shade-plugin</artifactId>