From 8075232cdd091b0354d5a33c3c3ef392f4d09114 Mon Sep 17 00:00:00 2001 From: yizhenqiang Date: Sun, 5 Aug 2018 09:05:55 +0800 Subject: [PATCH] Add volatile to methodNameMap and chainMap (#34) Modify MethodUtil#methodNameMap and CtSph#chainMap: add `volatile` to keep in line with others --- sentinel-core/src/main/java/com/alibaba/csp/sentinel/CtSph.java | 2 +- .../src/main/java/com/alibaba/csp/sentinel/util/MethodUtil.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sentinel-core/src/main/java/com/alibaba/csp/sentinel/CtSph.java b/sentinel-core/src/main/java/com/alibaba/csp/sentinel/CtSph.java index 21d178d6..2f958ee8 100755 --- a/sentinel-core/src/main/java/com/alibaba/csp/sentinel/CtSph.java +++ b/sentinel-core/src/main/java/com/alibaba/csp/sentinel/CtSph.java @@ -48,7 +48,7 @@ public class CtSph implements Sph { * Same resource({@link ResourceWrapper#equals(Object)}) will share the same * {@link ProcessorSlotChain}, no matter in which {@link Context}. */ - private static Map chainMap + private static volatile Map chainMap = new HashMap(); private static final Object LOCK = new Object(); diff --git a/sentinel-core/src/main/java/com/alibaba/csp/sentinel/util/MethodUtil.java b/sentinel-core/src/main/java/com/alibaba/csp/sentinel/util/MethodUtil.java index e4195da1..e8bc894d 100755 --- a/sentinel-core/src/main/java/com/alibaba/csp/sentinel/util/MethodUtil.java +++ b/sentinel-core/src/main/java/com/alibaba/csp/sentinel/util/MethodUtil.java @@ -29,7 +29,7 @@ import java.util.concurrent.ConcurrentHashMap; */ public final class MethodUtil { - private static Map methodNameMap = new HashMap(); + private static volatile Map methodNameMap = new HashMap(); private static final Object LOCK = new Object();