Browse Source

Polish code in Dubbo adapter and use Dubbo common constants (#1245)

master
echooymxq Eric Zhao 4 years ago
parent
commit
9cc52706f5
6 changed files with 18 additions and 6 deletions
  1. +3
    -1
      sentinel-adapter/sentinel-apache-dubbo-adapter/src/main/java/com/alibaba/csp/sentinel/adapter/dubbo/DubboAppContextFilter.java
  2. +3
    -1
      sentinel-adapter/sentinel-apache-dubbo-adapter/src/main/java/com/alibaba/csp/sentinel/adapter/dubbo/SentinelDubboConsumerFilter.java
  3. +3
    -1
      sentinel-adapter/sentinel-apache-dubbo-adapter/src/main/java/com/alibaba/csp/sentinel/adapter/dubbo/SentinelDubboProviderFilter.java
  4. +3
    -1
      sentinel-adapter/sentinel-dubbo-adapter/src/main/java/com/alibaba/csp/sentinel/adapter/dubbo/DubboAppContextFilter.java
  5. +3
    -1
      sentinel-adapter/sentinel-dubbo-adapter/src/main/java/com/alibaba/csp/sentinel/adapter/dubbo/SentinelDubboConsumerFilter.java
  6. +3
    -1
      sentinel-adapter/sentinel-dubbo-adapter/src/main/java/com/alibaba/csp/sentinel/adapter/dubbo/SentinelDubboProviderFilter.java

+ 3
- 1
sentinel-adapter/sentinel-apache-dubbo-adapter/src/main/java/com/alibaba/csp/sentinel/adapter/dubbo/DubboAppContextFilter.java View File

@@ -24,12 +24,14 @@ import org.apache.dubbo.rpc.Result;
import org.apache.dubbo.rpc.RpcContext; import org.apache.dubbo.rpc.RpcContext;
import org.apache.dubbo.rpc.RpcException; import org.apache.dubbo.rpc.RpcException;


import static org.apache.dubbo.common.constants.CommonConstants.CONSUMER;

/** /**
* Puts current consumer's application name in the attachment of each invocation. * Puts current consumer's application name in the attachment of each invocation.
* *
* @author Eric Zhao * @author Eric Zhao
*/ */
@Activate(group = "consumer")
@Activate(group = CONSUMER)
public class DubboAppContextFilter implements Filter { public class DubboAppContextFilter implements Filter {


@Override @Override


+ 3
- 1
sentinel-adapter/sentinel-apache-dubbo-adapter/src/main/java/com/alibaba/csp/sentinel/adapter/dubbo/SentinelDubboConsumerFilter.java View File

@@ -32,6 +32,8 @@ import org.apache.dubbo.rpc.RpcContext;
import org.apache.dubbo.rpc.RpcException; import org.apache.dubbo.rpc.RpcException;
import org.apache.dubbo.rpc.support.RpcUtils; import org.apache.dubbo.rpc.support.RpcUtils;


import static org.apache.dubbo.common.constants.CommonConstants.CONSUMER;

/** /**
* <p>Dubbo service consumer filter for Sentinel. Auto activated by default.</p> * <p>Dubbo service consumer filter for Sentinel. Auto activated by default.</p>
* <p> * <p>
@@ -43,7 +45,7 @@ import org.apache.dubbo.rpc.support.RpcUtils;
* @author Carpenter Lee * @author Carpenter Lee
* @author Eric Zhao * @author Eric Zhao
*/ */
@Activate(group = "consumer")
@Activate(group = CONSUMER)
public class SentinelDubboConsumerFilter extends BaseSentinelDubboFilter { public class SentinelDubboConsumerFilter extends BaseSentinelDubboFilter {


public SentinelDubboConsumerFilter() { public SentinelDubboConsumerFilter() {


+ 3
- 1
sentinel-adapter/sentinel-apache-dubbo-adapter/src/main/java/com/alibaba/csp/sentinel/adapter/dubbo/SentinelDubboProviderFilter.java View File

@@ -31,6 +31,8 @@ import org.apache.dubbo.rpc.Result;
import org.apache.dubbo.rpc.RpcContext; import org.apache.dubbo.rpc.RpcContext;
import org.apache.dubbo.rpc.RpcException; import org.apache.dubbo.rpc.RpcException;


import static org.apache.dubbo.common.constants.CommonConstants.PROVIDER;

/** /**
* <p>Apache Dubbo service provider filter that enables integration with Sentinel. Auto activated by default.</p> * <p>Apache Dubbo service provider filter that enables integration with Sentinel. Auto activated by default.</p>
* <p>Note: this only works for Apache Dubbo 2.7.x or above version.</p> * <p>Note: this only works for Apache Dubbo 2.7.x or above version.</p>
@@ -43,7 +45,7 @@ import org.apache.dubbo.rpc.RpcException;
* @author Carpenter Lee * @author Carpenter Lee
* @author Eric Zhao * @author Eric Zhao
*/ */
@Activate(group = "provider")
@Activate(group = PROVIDER)
public class SentinelDubboProviderFilter extends BaseSentinelDubboFilter { public class SentinelDubboProviderFilter extends BaseSentinelDubboFilter {


public SentinelDubboProviderFilter() { public SentinelDubboProviderFilter() {


+ 3
- 1
sentinel-adapter/sentinel-dubbo-adapter/src/main/java/com/alibaba/csp/sentinel/adapter/dubbo/DubboAppContextFilter.java View File

@@ -24,12 +24,14 @@ import com.alibaba.dubbo.rpc.Result;
import com.alibaba.dubbo.rpc.RpcContext; import com.alibaba.dubbo.rpc.RpcContext;
import com.alibaba.dubbo.rpc.RpcException; import com.alibaba.dubbo.rpc.RpcException;


import static com.alibaba.dubbo.common.Constants.CONSUMER;

/** /**
* Puts current consumer's application name in the attachment of each invocation. * Puts current consumer's application name in the attachment of each invocation.
* *
* @author Eric Zhao * @author Eric Zhao
*/ */
@Activate(group = "consumer")
@Activate(group = CONSUMER)
public class DubboAppContextFilter implements Filter { public class DubboAppContextFilter implements Filter {


@Override @Override


+ 3
- 1
sentinel-adapter/sentinel-dubbo-adapter/src/main/java/com/alibaba/csp/sentinel/adapter/dubbo/SentinelDubboConsumerFilter.java View File

@@ -31,6 +31,8 @@ import com.alibaba.dubbo.rpc.Invoker;
import com.alibaba.dubbo.rpc.Result; import com.alibaba.dubbo.rpc.Result;
import com.alibaba.dubbo.rpc.RpcException; import com.alibaba.dubbo.rpc.RpcException;


import static com.alibaba.dubbo.common.Constants.CONSUMER;

/** /**
* <p>Dubbo service consumer filter for Sentinel. Auto activated by default.</p> * <p>Dubbo service consumer filter for Sentinel. Auto activated by default.</p>
* *
@@ -42,7 +44,7 @@ import com.alibaba.dubbo.rpc.RpcException;
* @author leyou * @author leyou
* @author Eric Zhao * @author Eric Zhao
*/ */
@Activate(group = "consumer")
@Activate(group = CONSUMER)
public class SentinelDubboConsumerFilter extends AbstractDubboFilter implements Filter { public class SentinelDubboConsumerFilter extends AbstractDubboFilter implements Filter {


public SentinelDubboConsumerFilter() { public SentinelDubboConsumerFilter() {


+ 3
- 1
sentinel-adapter/sentinel-dubbo-adapter/src/main/java/com/alibaba/csp/sentinel/adapter/dubbo/SentinelDubboProviderFilter.java View File

@@ -32,6 +32,8 @@ import com.alibaba.dubbo.rpc.Invoker;
import com.alibaba.dubbo.rpc.Result; import com.alibaba.dubbo.rpc.Result;
import com.alibaba.dubbo.rpc.RpcException; import com.alibaba.dubbo.rpc.RpcException;


import static com.alibaba.dubbo.common.Constants.PROVIDER;

/** /**
* <p>Dubbo service provider filter for Sentinel. Auto activated by default.</p> * <p>Dubbo service provider filter for Sentinel. Auto activated by default.</p>
* *
@@ -43,7 +45,7 @@ import com.alibaba.dubbo.rpc.RpcException;
* @author leyou * @author leyou
* @author Eric Zhao * @author Eric Zhao
*/ */
@Activate(group = "provider")
@Activate(group = PROVIDER)
public class SentinelDubboProviderFilter extends AbstractDubboFilter implements Filter { public class SentinelDubboProviderFilter extends AbstractDubboFilter implements Filter {


public SentinelDubboProviderFilter() { public SentinelDubboProviderFilter() {


Loading…
Cancel
Save